Add new option for Prometheus chart legend #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option "table-large" for the Prometheus chart legend, which can be used to have a larger legend table, when there are a lot of values to display in the legend. We also changed the formatting of the values in the legend and in sparkline charts, so that they are rounded to a maximum of 4 decimals.
ricoberger
added a commit
that referenced
this pull request
Aug 11, 2021
Until now it was possible that the tooltip in the nivo charts wasn't completly visible. That should be fixed now. For that we are checking if the point for which the tooltip is shown is in the first half or second half of the chart. If it is in the first half the tooltip will be displayed on the right of the cursor and if it is in the second half the tooltip will be displayed on the right of the cursor. We also apply the roundNumber function, which was introduced in #107, in the table component of the Prometheus plugin. The "/api/health" endpoint is now excluded from all middlewares. This was changed, so that we do not spam metrics and logs with the values for this enpoint, because it makes finding the right logs in a Kubernetes environment with regular health check difficult. Last but not least we updated all the NPM packages, which we are using in the plugins.
3 tasks
ricoberger
added a commit
that referenced
this pull request
Aug 11, 2021
Until now it was possible that the tooltip in the nivo charts wasn't completly visible. That should be fixed now. For that we are checking if the point for which the tooltip is shown is in the first half or second half of the chart. If it is in the first half the tooltip will be displayed on the right of the cursor and if it is in the second half the tooltip will be displayed on the right of the cursor. We also apply the roundNumber function, which was introduced in #107, in the table component of the Prometheus plugin. The "/api/health" endpoint is now excluded from all middlewares. This was changed, so that we do not spam metrics and logs with the values for this enpoint, because it makes finding the right logs in a Kubernetes environment with regular health check difficult. Last but not least we updated all the NPM packages, which we are using in the plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option "table-large" for the Prometheus chart legend,
which can be used to have a larger legend table, when there are a lot of
values to display in the legend.
We also changed the formatting of the values in the legend and in
sparkline charts, so that they are rounded to a maximum of 4 decimals.