Fix dashboard tabs showing wrong variables #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now it was possible that a dashboard shows the wrong variables / the variables from another dashboard. This could happen when the user selected a dashboard with a larger index before another dashboard and then switched to a dashboard with a lower index. To fix this issue we do not use the mountOnEnter property from the Tabs component anymore. Instead we render all dashboards when the Dashboards component is rendered. To not load all the data for all dashboards we are passing the activeKey and eventKey from the Tabs component to the Dashboard component and only load the variables, when the activeKey is equal the eventKey.
ricoberger
force-pushed
the
fix-dashboard-tabs
branch
from
6da3228 to
fcedf27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now it was possible that a dashboard shows the wrong variables /
the variables from another dashboard. This could happen when the user
selected a dashboard with a larger index before another dashboard and
then switched to a dashboard with a lower index.
To fix this issue we do not use the mountOnEnter property from the Tabs
component anymore. Instead we render all dashboards when the Dashboards
component is rendered. To not load all the data for all dashboards we
are passing the activeKey and eventKey from the Tabs component to the
Dashboard component and only load the variables, when the activeKey is
equal the eventKey.