Fix Prometheus charts, when metrics are null #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the API call to get the metrics for a Prometheus chart returned null an error "null is not an object (evaluating 'e[Symbol.iterator]')" was thrown. This is now fixed, by checking if the metrics object is null and if this is the case we are returning an empty array instead of null in the data. This was already handled for the sparkline charts. We also showing all the dependencies of an application in the link list in the application details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the API call to get the metrics for a Prometheus chart returned
null an error "null is not an object (evaluating 'e[Symbol.iterator]')"
was thrown. This is now fixed, by checking if the metrics object is null
and if this is the case we are returning an empty array instead of null
in the data. This was already handled for the sparkline charts.
We also showing all the dependencies of an application in the link list
in the application details.