Allow multiple queries for Jaeger #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some days ago we change the Elasticsearch plugin to support multiple queries in the panel. In the same way we are chaning the options for the Jaeger plugin now. So that a user can specify multiple queries within a Jaeger panel. In the UI the user can then select the query he wants to see via the select box. This is a breaking change for the Jaeger panel, this means that old specification wont work anymore with the current version of kobs.
ricoberger
added a commit
that referenced
this pull request
Sep 9, 2021
In #130 we changed the options for the Jaeger plugin to allow multiple queries. For that we set the initial selected query to the first query from the "queries" property. This caused a bug, were the results were not refreshed after a user changed the service, operation, etc. on the Jaeger page, because we didn't updated the selected query. The selected query is now always updated when the queries property is changed and when it only contains one query, which is always the case for the page implementation of the Jaeger plugin. Fixes #142.
3 tasks
ricoberger
added a commit
that referenced
this pull request
Sep 9, 2021
In #130 we changed the options for the Jaeger plugin to allow multiple queries. For that we set the initial selected query to the first query from the "queries" property. This caused a bug, were the results were not refreshed after a user changed the service, operation, etc. on the Jaeger page, because we didn't updated the selected query. The selected query is now always updated when the queries property is changed and when it only contains one query, which is always the case for the page implementation of the Jaeger plugin. Fixes #142.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some days ago we change the Elasticsearch plugin to support multiple
queries in the panel. In the same way we are chaning the options for the
Jaeger plugin now. So that a user can specify multiple queries within a
Jaeger panel. In the UI the user can then select the query he wants to
see via the select box.
This is a breaking change for the Jaeger panel, this means that old
specification wont work anymore with the current version of kobs.