Allow users to select a time range in logs chart #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to select a new time range in the logs chart of the ClickHouse plugin. This allows users to zoom into a smaller time range to view the returned logs. For this feature we switched from nivo charts to the patternfly/react-charts charting package. This package comes with a built in function for "brushing" which makes it easier to provide this feature. NOTE: For the charts in the other plugins like Prometheus and Jaeger we can adjust the style of the charts to follow the styling from the patternfly/react-charts package. This could provide a better overall user experience for all charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to select a new time range in the logs chart of the
ClickHouse plugin. This allows users to zoom into a smaller time range
to view the returned logs.
For this feature we switched from nivo charts to the
patternfly/react-charts charting package. This package comes with a
built in function for "brushing" which makes it easier to provide this
feature.
NOTE: For the charts in the other plugins like Prometheus and Jaeger we
can adjust the style of the charts to follow the styling from the
patternfly/react-charts package. This could provide a better overall
user experience for all charts.