Skip to content

Conversation

ricoberger
Copy link
Member

This commit removes the legend from the LogsChart component, because on
some zoom levels the legend was displayed, which we do not want.

We are also using the useDimensions hook from the core package now,
instead the custom implementation tp determine the height and width of
the chart. For this we also added an option to specify a default for the
width and height, because the Patternfly charts package logs some errors
when the initial width / height is zero and this ways we can set it to
1.

This commit removes the legend from the LogsChart component, because on
some zoom levels the legend was displayed, which we do not want.

We are also using the useDimensions hook from the core package now,
instead the custom implementation tp determine the height and width of
the chart. For this we also added an option to specify a default for the
width and height, because the Patternfly charts package logs some errors
when the initial width / height is zero and this ways we can set it to
1.
@ricoberger ricoberger merged commit 097e072 into main Oct 5, 2021
@ricoberger ricoberger deleted the use-usedimensions-hook branch October 5, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant