Use multiple colors in the Jaeger plugin #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jaeger plugin uses multiple colors now. Right after a trace was returned from the gRPC service, we loop through all traces and their processes and asign each process a color. This color is then used in the list of spans for the service and in the chart of spans and spans view. This also fixes a bug, where the specified traces where not used in the API. The tags specified by the user will now be used for the Jaeger API calls. For that we transform the string into a json object. This object is then encoded and the encoded string is sent to our gRPC server. Besides the mentioned changes from above, we also added two function, to check if a trace/span contains a tag "error=true". If this is the case, we display a error icon next to the trace/span id in the title.
ricoberger
force-pushed
the
use-multiple-colors-in-the-jaeger-plugin
branch
from
b1b0211 to
b4bd473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jaeger plugin uses multiple colors now. Right after a trace was
returned from the gRPC service, we loop through all traces and their
processes and asign each process a color. This color is then used in the
list of spans for the service and in the chart of spans and spans view.
This also fixes a bug, where the specified traces where not used in the
API. The tags specified by the user will now be used for the Jaeger API
calls. For that we transform the string into a json object. This object
is then encoded and the encoded string is sent to our gRPC server.
Besides the mentioned changes from above, we also added two function, to
check if a trace/span contains a tag "error=true". If this is the case,
we display a error icon next to the trace/span id in the title.