Rework usage of icons, links handling and drawer layout #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now we had used the icons by importing them directly from their corresponding file. Now we are using the "@patternfly/react-icons" package to import the icons. The links handling wasn't unified accross the frontend. Now we are using a new approach by wrapping components in a new "LinksWrapper" component so that each link is opened within kobs by default. This allows the user to decide if he wants to open a link in a new tab or in the current one. The drawer layour was completly changed. We had a helper variable "isInDrawer" to apply a specific layout, when a component was displayed within the Apllication drawer. This variable was removed. Instead we are always using the same layout. We also removed the "isFlat" property from most of the "Card" components to have a consistent style accross all components. Last but not least we wrapped most of the components in a "Card" component to be consistent with other components, which were already displayed in cards.
ricoberger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we had used the icons by importing them directly from their
corresponding file. Now we are using the "@patternfly/react-icons"
package to import the icons.
The links handling wasn't unified accross the frontend. Now we are using
a new approach by wrapping components in a new "LinksWrapper" component
so that each link is opened within kobs by default. This allows the user
to decide if he wants to open a link in a new tab or in the current one.
The drawer layour was completly changed. We had a helper variable
"isInDrawer" to apply a specific layout, when a component was displayed
within the Apllication drawer. This variable was removed. Instead we are
always using the same layout. We also removed the "isFlat" property from
most of the "Card" components to have a consistent style accross all
components. Last but not least we wrapped most of the components in a
"Card" component to be consistent with other components, which were
already displayed in cards.