Add preview for Applications via plugins #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new "plugin" field to the details section of the Application CR. This allows a user to specify a plugin, which is then used as preview for the Application in the Application overview page. At the moment a user can specify a Prometheus or Elasticsearch query for the preview. When this is specified the corresponding Prometheus chart with the metrics for the query, or the number of hits and the buckets chart will be displayed in the Application card. If the user doesn't specify a plugin, we will display the provided description of the Application. This commit also fixes a small bug, where the list of resources wasn't updated correctly, because we missed to compare the properties in the "React.memo" function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new "plugin" field to the details section of the
Application CR. This allows a user to specify a plugin, which is then
used as preview for the Application in the Application overview page.
At the moment a user can specify a Prometheus or Elasticsearch query for
the preview. When this is specified the corresponding Prometheus chart
with the metrics for the query, or the number of hits and the buckets
chart will be displayed in the Application card. If the user doesn't
specify a plugin, we will display the provided description of the
Application.
This commit also fixes a small bug, where the list of resources wasn't
updated correctly, because we missed to compare the properties in the
"React.memo" function.