[core] Improve the search on select components #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staffbase-robert
changed the title
|
Hi @staffbase-robert, please add your change to the [CHANGELOG][https://github.com/kobsio/kobs/blob/main/CHANGELOG.md) 🙏🏼 |
axdotl
changed the title
This improves the filtering in select components, so that also entries are matched, which are containing a string but do not start with the search string provided by the user. This commit runs prittier in the fixed files and fixes some eslint errors. I also changed the key property on most of the components to improve the rendering.
ricoberger
changed the title
|
Hi @staffbase-robert, thanks for your contribution 🙂. I made some small adjustments in c131c53 and added a changelog entry how @axdotl suggested. |
ricoberger
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[plugins]: improve the search on select components
onFilterproperty to the<Select/>components.