[core] Switch to zap for logging #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using "go.uber.org/zap" for logging instead of "github.com/sirupsen/logrus". It is now also possible to enrich each log line via a context. This way we can add the "userID" and "requestID" to most of the log lines and we can add additional fields to the logging context via the "ContextWithValue" function. For that we should always use our custom "github.com/kobsio/kobs/pkg/log" package instead of directly using zap.
ricoberger
force-pushed
the
core-switch-to-zap-for-logging
branch
from
12ce72f to
83100be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using "go.uber.org/zap" for logging instead of
"github.com/sirupsen/logrus".
It is now also possible to enrich each log line via a context. This way
we can add the "userID" and "requestID" to most of the log lines and we
can add additional fields to the logging context via the
"ContextWithValue" function. For that we should always use our custom
"github.com/kobsio/kobs/pkg/log" package instead of directly using zap.