[dashboards] Refactor defaults and placeholders #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
dashboards-refactor-defaults-placeholders-and-variables-handling
branch
2 times, most recently
from
f2cd3e7 to
1859737
Compare
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 42.68% 42.96% +0.28%
==========================================
Files 93 94 +1
Lines 7926 7927 +1
==========================================
+ Hits 3383 3406 +23
+ Misses 4506 4490 -16
+ Partials 37 31 -6
Continue to review full report at Codecov.
|
ricoberger
force-pushed
the
dashboards-refactor-defaults-placeholders-and-variables-handling
branch
from
1859737 to
bcc8f45
Compare
This is a breaking change for the defaults and placeholders handling in
dashboards. We removed the "defaults" option for dashboards, so that
users must now set the cluster / namespace in all plugins. Before this
they were optional in all plugins which had a cluster(s) or namespace(s)
option. As a replacement for this we introduced two new special
variables. These are "__cluster" and "__namespace" which containing the
cluster and namespace of an Application or a Team were the dashboard is
used.
We also changed the behaviour of placeholders, so that they are now more
like variables. This means placeholders must now be used with the
following syntax "{% .<placeholder-name> %}". The old "{{
.<placeholder-name> }}" syntax doesn't work anymore.
Another change is that the defaults (cluster / namespace) in the CRDs
are now replaced on the server side and not in the frontend anymore.
This shouldn't have any effect for the end user.
ricoberger
force-pushed
the
dashboards-refactor-defaults-placeholders-and-variables-handling
branch
from
bcc8f45 to
626021e
Compare
ricoberger
deleted the
dashboards-refactor-defaults-placeholders-and-variables-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for the defaults and placeholders handling in
dashboards. We removed the "defaults" option for dashboards, so that
users must now set the cluster / namespace in all plugins. Before this
they were optional in all plugins which had a cluster(s) or namespace(s)
option. As a replacement for this we introduced two new special
variables. These are
__clusterand__namespacewhich containing thecluster and namespace of an Application or a Team were the dashboard is
used.
We also changed the behavior of placeholders, so that they are now more
like variables. This means placeholders must now be used with the
following syntax
{% .<placeholder-name> %}. The old{{.<placeholder-name> }}syntax doesn't work anymore.Another change is that the defaults (cluster / namespace) in the CRDs
are now replaced on the server side and not in the frontend anymore.
This shouldn't have any effect for the end user.