Allow users to overwrite the plugin name #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now we always used the plugin name in the tabs list for Applications and Kubernetes resources. Now it is possible to overwrite this name with the new "displayName" field. This could be useful in cases where one plugin is used multiple times within an Applications or resource. For example the Prometheus plugin can be used multiple time: In the first tab it is used to display the application metrics and in a second tab it is used to display the Istio metrics for this application.
ricoberger
force-pushed
the
add-displayname-field-for-plugins
branch
from
a9ae7e8 to
bee7137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we always used the plugin name in the tabs list for
Applications and Kubernetes resources. Now it is possible to overwrite
this name with the new "displayName" field.
This could be useful in cases where one plugin is used multiple times
within an Applications or resource. For example the Prometheus plugin
can be used multiple time: In the first tab it is used to display the
application metrics and in a second tab it is used to display the Istio
metrics for this application.