[app] Fix plugin filter #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the filter on the plugin instances page. We didn't used the plugin id as key for rendering the plugin gallery items, which lead to some strange behaviour, so that plugins were still shown also when the filter was changed. This should be fixed now. It is now also possible to filter the list of plugins by the name of a satellite, so that only plugins are shown that are configured at the specific satellite instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the filter on the plugin instances page. We didn't
used the plugin id as key for rendering the plugin gallery items, which
lead to some strange behaviour, so that plugins were still shown also
when the filter was changed. This should be fixed now.
It is now also possible to filter the list of plugins by the name of a
satellite, so that only plugins are shown that are configured at the
specific satellite instance.