[app] Change URLs for Application / Dashboard page #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since our IDs are containing a slash ("/") to seperate the different
parts (satellite, cluster, namespace and name) we had to encode the ID
to use it as parameter in the React Router. This is not working
properly, so that it can happen that the encoded slash character is
replaced by a real slash when a user reloads an URL. This leads to the
situation that React Router isn't aware of this url format and so
nothing is rendered.
We decided to adjust the URLs in React Router, so that we can still use
slashes in our IDs, but instead of just a "type" parameter, we now have
a parameter for every id part, which results in the following routes:
- /applications/satellite/:satellite/cluster/:cluster/namespace/:namespace/name/:name
- /dashboards/satellite/:satellite/cluster/:cluster/namespace/:namespace/name/:name
ricoberger
force-pushed
the
app-change-urls-for-application-and-dashboard-page
branch
from
437dfe4 to
6443045
Compare
ricoberger
deleted the
app-change-urls-for-application-and-dashboard-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our IDs are containing a slash ("/") to seperate the different
parts (satellite, cluster, namespace and name) we had to encode the ID
to use it as parameter in the React Router. This is not working
properly, so that it can happen that the encoded slash character is
replaced by a real slash when a user reloads an URL. This leads to the
situation that React Router isn't aware of this url format and so
nothing is rendered.
We decided to adjust the URLs in React Router, so that we can still use
slashes in our IDs, but instead of just a "type" parameter, we now have
a parameter for every id part, which results in the following routes: