Add value mappings for sparkline charts #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparkline charts in the Prometheus plugin are supporting value mappings now. This allows a user to specify a map to overwrite the displayed value. We also fixed a bug for NaN values in the charts. The used charting library doesn't support NaN values, so we have to convert them to "null" before the chart is rendered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparkline charts in the Prometheus plugin are supporting value mappings
now. This allows a user to specify a map to overwrite the displayed
value.
We also fixed a bug for NaN values in the charts. The used charting
library doesn't support NaN values, so we have to convert them to "null"
before the chart is rendered.