Add command-line flag to forbid resource access #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new command-line flag "--clusters.forbidden-resources", which can be used to forbid access to a list of resources. This allow a user to still use RBAC with wildcards for the permissions of kobs, but do not allow a user to access the specified resources. We also adjusted the corresponding React component, so that the error is now shown to the user. This also fixes a problem, where the app crashed, whenn the empty state was clicked in the resources list.
ricoberger
force-pushed
the
forbid-access-for-resources-via-command-line-flag
branch
from
553d9c3 to
5d06744
Compare
ricoberger
deleted the
forbid-access-for-resources-via-command-line-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new command-line flag
"--clusters.forbidden-resources", which can be used to forbid access to
a list of resources. This allow a user to still use RBAC with wildcards
for the permissions of kobs, but do not allow a user to access the
specified resources.
We also adjusted the corresponding React component, so that the error is
now shown to the user. This also fixes a problem, where the app
crashed, whenn the empty state was clicked in the resources list.