Share datasource options between components #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the handling of the datasource options, so that they are shared between the components for the Application details. This allows us to use the same time range for metrics, logs and traces. For that the datasource options are now handled in the parent component of the different view, instead of the Metrics, Logs, Traces component. This also allows us, to reflect the changes of the options in the current URL via query parameters, so that a user can share his current view with other users and they see the same time range. Note: Maybe we can do sth. similar also for the users selected variables, so that he also can share these values with other users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the handling of the datasource options, so that they are
shared between the components for the Application details. This allows
us to use the same time range for metrics, logs and traces.
For that the datasource options are now handled in the parent component
of the different view, instead of the Metrics, Logs, Traces component.
This also allows us, to reflect the changes of the options in the
current URL via query parameters, so that a user can share his current
view with other users and they see the same time range.
Note: Maybe we can do sth. similar also for the users selected
variables, so that he also can share these values with other users.