Fix time parsing for the datasource options #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user provided time string wasn't parsed correctly. We used the provided start time also for the end time by mistak. Also the provided string was always parsed as UTC date instead of the users current timezone. Both issues are fixed now. We also added a new input field for the Prometheus resolution. This option was already present, but the input field was missing. So that a user wasn't able to change the resolution. The resolution is displayed in a fourth column in the options modal. This column should also be used for other datasources (e.g. max results for Jaeger).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user provided time string wasn't parsed correctly. We used the
provided start time also for the end time by mistak. Also the provided
string was always parsed as UTC date instead of the users current
timezone. Both issues are fixed now.
We also added a new input field for the Prometheus resolution. This
option was already present, but the input field was missing. So that a
user wasn't able to change the resolution. The resolution is displayed
in a fourth column in the options modal. This column should also be used
for other datasources (e.g. max results for Jaeger).