Add support for Kiali metrics #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricoberger
force-pushed
the
add-kiali-metrics
branch
from
972410b to
6954747
Compare
The Kiali plugin supports all the metrics from Kiali now. This means when a user selects an edge or node in the Kiali topology graph he also sees the metrics for TCP, HTTP and gRPC traffic. To get these metrics we are using the 'metrics' endpoint of the configured Kiali instance. Instead of the custom duration dropdown we are now using the Option component from the core package to select the duration (time range) for which the graph should be rendered. It is important to now that the time range only works for the metrics, for the values in the topology graph only the difference between the start and end time is used.
ricoberger
force-pushed
the
add-kiali-metrics
branch
from
6954747 to
d49b9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kiali plugin supports all the metrics from Kiali now. This means
when a user selects an edge or node in the Kiali topology graph he also
sees the metrics for TCP, HTTP and gRPC traffic. To get these metrics we
are using the 'metrics' endpoint of the configured Kiali instance.
Instead of the custom duration dropdown we are now using the Option
component from the core package to select the duration (time range) for
which the graph should be rendered. It is important to now that the time
range only works for the metrics, for the values in the topology graph
only the difference between the start and end time is used.