Skip to content

Conversation

@kobylynskyi
Copy link
Owner

@kobylynskyi kobylynskyi commented May 27, 2020

@lmartellotto could you please review?


Resolves #153

@kobylynskyi kobylynskyi added the enhancement New feature or request label May 27, 2020
@kobylynskyi kobylynskyi self-assigned this May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #155 into master will increase coverage by 0.18%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     90.51%   90.69%   +0.18%     
- Complexity      461      476      +15     
============================================
  Files            51       52       +1     
  Lines          1075     1118      +43     
  Branches        139      147       +8     
============================================
+ Hits            973     1014      +41     
- Misses           68       69       +1     
- Partials         34       35       +1     
Impacted Files Coverage Δ Complexity Δ
.../graphql/codegen/model/MappingConfigConstants.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...degen/model/graphql/GraphQLResponseProjection.java 86.66% <86.66%> (ø) 5.00 <5.00> (?)
...i/graphql/codegen/FreeMarkerTemplatesRegistry.java 84.21% <100.00%> (+0.87%) 1.00 <0.00> (ø)
...om/kobylynskyi/graphql/codegen/GraphQLCodegen.java 97.10% <100.00%> (+0.15%) 47.00 <0.00> (+3.00)
...degen/mapper/FieldDefinitionToParameterMapper.java 97.56% <100.00%> (+0.19%) 20.00 <1.00> (+1.00)
...obylynskyi/graphql/codegen/mapper/MapperUtils.java 87.50% <100.00%> (+1.01%) 21.00 <1.00> (+1.00)
...odegen/mapper/TypeDefinitionToDataModelMapper.java 98.73% <100.00%> (+0.18%) 24.00 <2.00> (+1.00)
...bylynskyi/graphql/codegen/model/MappingConfig.java 92.00% <100.00%> (+0.21%) 62.00 <1.00> (+2.00)
...ylynskyi/graphql/codegen/model/MappingContext.java 90.62% <100.00%> (+0.30%) 29.00 <1.00> (+1.00)
...l/codegen/model/ProjectionParameterDefinition.java 71.42% <100.00%> (+4.76%) 5.00 <1.00> (+1.00)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173f595...1fee897. Read the comment docs.

protected final Map<String, GraphQLParametrizedInput> parametrizedInputs = new LinkedHashMap<>();

@Override
public String toString() {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved out from generated ResponseProjection classes because the code is identical for all of them.

@kobylynskyi kobylynskyi marked this pull request as ready for review May 27, 2020 03:33
@kobylynskyi kobylynskyi requested a review from joffrey-bion May 27, 2020 03:33
@kobylynskyi
Copy link
Owner Author

@joffrey-bion please review when you have time. Thanks!

@joffrey-bion
Copy link
Contributor

Looks good to me! Nice job!

@kobylynskyi kobylynskyi merged commit 97c7171 into master May 27, 2020
@kobylynskyi kobylynskyi deleted the 153-parametrized-fields-response-projection branch May 27, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support of parametrized fields in ResponseProjection

3 participants