-
-
Notifications
You must be signed in to change notification settings - Fork 114
Support of parametrized fields in ResponseProjection #153 #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of parametrized fields in ResponseProjection #153 #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
============================================
+ Coverage 90.51% 90.69% +0.18%
- Complexity 461 476 +15
============================================
Files 51 52 +1
Lines 1075 1118 +43
Branches 139 147 +8
============================================
+ Hits 973 1014 +41
- Misses 68 69 +1
- Partials 34 35 +1 Continue to review full report at Codecov.
|
| protected final Map<String, GraphQLParametrizedInput> parametrizedInputs = new LinkedHashMap<>(); | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was moved out from generated ResponseProjection classes because the code is identical for all of them.
|
@joffrey-bion please review when you have time. Thanks! |
|
Looks good to me! Nice job! |
@lmartellotto could you please review?
Resolves #153