Fix Sonar issues #666
Merged
Fix Sonar issues #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kobylynskyi
requested changes
Apr 23, 2021
src/main/java/com/kobylynskyi/graphql/codegen/mapper/GraphQLTypeMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kobylynskyi/graphql/codegen/model/definitions/ExtendedDefinition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kobylynskyi/graphql/codegen/model/definitions/ExtendedDefinition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kobylynskyi/graphql/codegen/model/definitions/ExtendedDefinition.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 23, 2021 12:51
robbertnoordzij
force-pushed
the
develop
branch
from
ec8a6b0 to
0b57d1a
Compare
jxnu-liguobin
approved these changes
Apr 23, 2021
kobylynskyi
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was not sure if someone was already fixing the NPE warning from Sonar. I also removed the code duplication that was introduced with my previous PR and I added the generic hints to the NameNode.
Changes were made to: