Ability to add custom operation name for request #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobylynskyi
requested changes
May 6, 2021
src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequests.java
Outdated
Show resolved
Hide resolved
kobylynskyi
requested changes
May 10, 2021
src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequests.java
Show resolved
Hide resolved
src/main/java/com/kobylynskyi/graphql/codegen/model/graphql/GraphQLRequest.java
Outdated
Show resolved
Hide resolved
…aphQLRequests.java Co-authored-by: Bogdan Kobylynskyi <92bogdan@gmail.com>
…aphQLRequest.java Co-authored-by: Bogdan Kobylynskyi <92bogdan@gmail.com>
kobylynskyi
approved these changes
May 11, 2021
Owner
There was a problem hiding this comment.
@robbertnoordzij Good job. Thanks for the contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the suggestion by @kobylynskyi, I added the ability to override the operation name in queries. While to comment states that a multi request does not have an operation name it is actually possible based on the documentation.
Am I missing something?
Related to #681
Changes were made to: