Skip to content

Address issue 20#21

Merged
koheiw merged 10 commits intomasterfrom
issue-20-2
Sep 2, 2021
Merged

Address issue 20#21
koheiw merged 10 commits intomasterfrom
issue-20-2

Conversation

@koheiw
Copy link
Copy Markdown
Owner

@koheiw koheiw commented Sep 2, 2021

Add use_nan argument for #20. simil(method = "correlation", use_nan = TRUE) will return NaN for vectors without variance.

I am happy to change the name of the argument if @rcannood can has a better idea.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2021

Codecov Report

Merging #21 (750c5b9) into master (fde2242) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   99.11%   99.15%   +0.04%     
==========================================
  Files           4        4              
  Lines         338      355      +17     
==========================================
+ Hits          335      352      +17     
  Misses          3        3              
Impacted Files Coverage Δ
R/proxy.R 99.04% <100.00%> (+0.04%) ⬆️
src/linear.cpp 98.78% <100.00%> (+0.09%) ⬆️
src/pair.cpp 99.25% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde2242...750c5b9. Read the comment docs.

@koheiw koheiw requested a review from rcannood September 2, 2021 04:39
Copy link
Copy Markdown
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! おつかれさまでした!

I added one more commit which renames 'nan' to 'use_nan' to avoid naming conflicts between the parameter 'nan' and the function 'std::nan', just in case.

@koheiw
Copy link
Copy Markdown
Owner Author

koheiw commented Sep 2, 2021

@rcannood thank you for reviewing. I will update CRAN soon.

@koheiw koheiw merged commit 4d50b28 into master Sep 2, 2021
@koheiw koheiw deleted the issue-20-2 branch September 2, 2021 08:53
@koheiw koheiw mentioned this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants