Skip to content

Fix symmetry testing#4

Merged
koheiw merged 3 commits intokoheiw:masterfrom
dynverse:fix_symmetry_testing
Apr 18, 2019
Merged

Fix symmetry testing#4
koheiw merged 3 commits intokoheiw:masterfrom
dynverse:fix_symmetry_testing

Conversation

@rcannood
Copy link
Copy Markdown
Collaborator

This is a fix for #3. The first commit (db9f60f) add tests to verify whether proxyC produces the correct results, even when x and y have the same dimensionality. The second commit (7df91ee) fixes the problem by adding a boolean argument that allows to specify whether the output matrix will be symmetric.

@rcannood
Copy link
Copy Markdown
Collaborator Author

rcannood commented Apr 18, 2019

Thanks for merging #2! I merged koheiw/proxyC@master into my branch, in order to enable travis for this PR.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 18, 2019

Codecov Report

Merging #4 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #4     +/-   ##
=========================================
+ Coverage   92.85%   93.16%   +0.3%     
=========================================
  Files           4        4             
  Lines         266      278     +12     
=========================================
+ Hits          247      259     +12     
  Misses         19       19
Impacted Files Coverage Δ
src/pair.cpp 83.65% <100%> (ø) ⬆️
R/proxy.R 98.68% <100%> (+0.24%) ⬆️
src/linear.cpp 98.41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5921b6f...a36886a. Read the comment docs.

@koheiw koheiw merged commit 2c02069 into koheiw:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants