Merged
Conversation
Collaborator
Author
|
Thanks for merging #2! I merged koheiw/proxyC@master into my branch, in order to enable travis for this PR. |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=========================================
+ Coverage 92.85% 93.16% +0.3%
=========================================
Files 4 4
Lines 266 278 +12
=========================================
+ Hits 247 259 +12
Misses 19 19
Continue to review full report at Codecov.
|
koheiw
approved these changes
Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #3. The first commit (db9f60f) add tests to verify whether proxyC produces the correct results, even when x and y have the same dimensionality. The second commit (7df91ee) fixes the problem by adding a boolean argument that allows to specify whether the output matrix will be symmetric.