Skip to content

Conversation

@kelchen123
Copy link
Member

Author's Checklist

  • I understand the problem that the PR is trying to address.
  • I understand the solution and its role and impact within the wider system.
  • I opted for automation and automated tests over documenting multiple steps.

Reviewer's Guide

  • What is the PR trying to solve?
  • Does the solution make sense?
  • How does this affect the wider system?
  • Is it being tested properly?
  • Does it keep documentation concise and maintainable?

@kelchen123 kelchen123 requested a review from a team as a code owner October 1, 2025 21:05
@kelchen123 kelchen123 marked this pull request as draft October 2, 2025 15:48
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch 13 times, most recently from 9573562 to fe74839 Compare October 8, 2025 17:13
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch from fe74839 to 8dbc5c8 Compare October 8, 2025 17:23
@kelchen123 kelchen123 marked this pull request as ready for review October 8, 2025 18:48
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch 2 times, most recently from 53b76c8 to 2a52cce Compare October 9, 2025 13:49
@kelchen123 kelchen123 closed this Oct 9, 2025
@kelchen123 kelchen123 reopened this Oct 9, 2025
@kelchen123 kelchen123 requested a review from amisstea October 9, 2025 17:15
@kelchen123 kelchen123 closed this Oct 9, 2025
@kelchen123 kelchen123 reopened this Oct 9, 2025
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch 2 times, most recently from 454dca1 to e832663 Compare October 9, 2025 18:00
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch from e832663 to 5351ed7 Compare October 10, 2025 18:52
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch from 5351ed7 to b595f2a Compare October 10, 2025 18:54
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch from b595f2a to 7880b09 Compare October 10, 2025 18:59
@avi-biton
Copy link
Contributor

avi-biton commented Oct 16, 2025

My concern is that we will need manual intervention to update dependencies, and I am not sure we want to go down this path.
As mentioned in the stand up meeting, lets try to understand what is the level of manual intervention, is it something we will need to do all the time, or is it a once in while (which we might find reasonable for us).

I think we need to investigate it further before making the change

@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch from 204dcd0 to e756c7f Compare October 22, 2025 15:56
@kelchen123 kelchen123 force-pushed the enable-hermetic-builds-clean branch from e756c7f to bc567d7 Compare October 22, 2025 17:20
@kelchen123 kelchen123 requested a review from amisstea October 22, 2025 17:54
@kelchen123 kelchen123 added this pull request to the merge queue Oct 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@kelchen123 kelchen123 added this pull request to the merge queue Oct 22, 2025
Merged via the queue into konflux-ci:main with commit 6b793cd Oct 22, 2025
8 checks passed
@kelchen123 kelchen123 deleted the enable-hermetic-builds-clean branch October 22, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants