chore: improve basic reconciliation for KongPluginInstallation#560
Merged
programmer04 merged 1 commit intomainfrom Sep 9, 2024
Merged
chore: improve basic reconciliation for KongPluginInstallation#560programmer04 merged 1 commit intomainfrom
programmer04 merged 1 commit intomainfrom
Conversation
programmer04
force-pushed
the
kpi-adjustments
branch
from
5035e91 to
4ab8fc3
Compare
programmer04
force-pushed
the
kpi-adjustments
branch
from
4ab8fc3 to
4355ab9
Compare
randmonkey
approved these changes
Sep 9, 2024
programmer04
pushed a commit
that referenced
this pull request
Nov 12, 2025
…eason (#560) * add controlPlaneOptionsValid condition type and reason * Apply suggestions from code review Co-authored-by: Patryk Małek <patryk.malek@konghq.com> --------- Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow-up for PRs #424 & #474, prerequisite for
it contains a handful of improvements
Makefilealigned with skaffold configurationKongPluginInstallation(the same as other resources do)KongPluginInstallationa particularConfigMapresponds (label can't be used for this due to length limitation)Pendingwhen it's not yet known if the plugin will be fetched successfully or notWhich issue this PR fixes
Part of #379
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes