fix: browser kill after first task completion caused by context reset #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create isolated browser contexts for each task to prevent conflicts - Replace global browser context with task-specific instances - Add proper resource cleanup in finally blocks to prevent memory leaks - Extract hardcoded values as constants for better maintainability - Add comprehensive type hints throughout the codebase - Improve error handling and logging - Reorganize imports and improve code structure - Update Dockerfile to use Playwright's bundled browser instead of custom Chrome - Ensure each task runs in its own isolated environment with unique debugging ports - Fix potential race conditions when multiple tasks access the same context
Contributor
Author
|
feat: Improve browser task isolation and resource management
|
- Removed extra empty lines in Dockerfile (lines 16, 69, 72) - Implemented Docker secrets for VNC password with fallback mechanism - Created centralized environment variable handling with init_configuration() - Fixed import errors by updating to langchain_core - Kept Any type annotations where browser-use specific types weren't accessible - Added server startup sanity checks for port, dimensions, expiry time - Removed redundant src directory - Updated README with Docker secrets instructions
hashkode
approved these changes
Mar 18, 2025
Contributor
Author
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.