fix(auth): classify invalid_grant refresh errors as permanent#55
Open
VishiATChoudhary wants to merge 1 commit intomainfrom
Open
fix(auth): classify invalid_grant refresh errors as permanent#55VishiATChoudhary wants to merge 1 commit intomainfrom
VishiATChoudhary wants to merge 1 commit intomainfrom
Conversation
The oauth2 library returns a *RetrieveError when the token endpoint rejects a refresh with invalid_grant. Previously RefreshSession wrapped this generically, so callers could not distinguish permanent refresh-token revocation from transient errors (network, 5xx, etc). Introduce ErrInvalidGrant as a sentinel that callers can detect via errors.Is. This unlocks graceful shutdown on permanent auth loss in the sidecar (follow-up PRs). Refs #54
5 tasks
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
VishiATChoudhary
requested review from
tumberger
and removed request for
michiosw
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
go test ./...go test -race ./...go vet ./...buf generateif protobuf or generated code changedRelease notes