This repository was archived by the owner on Sep 6, 2020. It is now read-only.
add isConnected method and remove incorrect annotations. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I converted my application from AutobahnAndroid to android-websockets to take advantage of ssl support. android-websockets did not have a isConnected method, which is used in my application, so I implemented one.
Owner
|
java 6 (which is the target on this project) uses @OverRide on interfaces. |
Owner
|
Please split the changes into two pulls, as I would happily accept the first, but I fail to see the point of the second |
Author
|
It appears that my java target version was erroneously set to 1.5. |
koush
added a commit
that referenced
this pull request
Apr 8, 2013
add isConnected method and remove incorrect annotations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a change I had to make while converting my application from AutobahnAndroid to android-websockets to take advantage of the latter's ssl support.