Set up project #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seddonym
commented
Sep 12, 2024
There was a problem hiding this comment.
This is just following the instructions in the cookie cutter template. The project doesn't have any production package dependencies so there's no need to do matrix testing along those lines.
seddonym
commented
Sep 12, 2024
| @@ -0,0 +1,189 @@ | |||
| # Contributing | |||
There was a problem hiding this comment.
All of these docs are not relevant to consumers of the package, only to contributors.
seddonym
commented
Sep 12, 2024
dooferlad
approved these changes
Sep 12, 2024
khorn
approved these changes
Sep 12, 2024
README.md
Outdated
| TODO describe the purpose of 'rustfluent' here. | ||
| A Python interface to the Rust Fluent Library. | ||
|
|
||
| This project is a shall shim around [fluent-rs](https://github.com/projectfluent/fluent-rs), so it |
Co-authored-by: James Tunnicliffe <james.tunnicliffe@nanosheep.org>
This is required to get the test passing.
It isn't working at the moment, not sure it's worth supporting unless someone requests it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up a few basics for the project - dev requirements, docs, license, github actions etc.
What this builds on
Builds on this commit, which is at the time of writing the only commit on the project.
That commit was generating using using
cookiecutter gh:octoenergy/cookiecutter-kraken-package.I changed one small thing before committing it: I renamed the package from
kraken.rustfluentjust torustfluentas it didn't feel the namespace was appropriate in this case.