8.x #1036
Open
8.x #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 7.x #1036 +/- ##
============================================
- Coverage 88.54% 88.36% -0.18%
- Complexity 1461 1473 +12
============================================
Files 145 145
Lines 4145 4144 -1
============================================
- Hits 3670 3662 -8
- Misses 475 482 +7 🚀 New features to boost your workflow:
|
jeromegamez
force-pushed
the
8.x
branch
2 times, most recently
from
45e7620 to
5d2ab01
Compare
`Throwable::getCode()` can be non-int.
Methods that previously accepted `Stringable|string` as argument types
now only support `string`.
`Stringable` was added for convenience so that someone could do,
for example
```php
$user = $auth->getUser('uid');
$auth->updateUser($user, [...]);
```
While convenient, this adds overhead when processing these arguments.
For example, if a method expects a non-empty string, the SDK would
have to do a `trim((string) $arg)` and check if it's empty.
With this change, we can rely only on a `@var non-empty-string $arg`
docblock annotation.
```php
$user = $auth->getUser('uid');
$auth->updateUser($user->uid, [...]);
```
But ignore unavoidable interface returns on public APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking PR for 8.x development
Discussion
Stringable|stringargument types withstring-only #1042Notes