Skip to content

Allow to add multiple configuration file to configmap #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2019
Merged

Allow to add multiple configuration file to configmap #66

merged 1 commit into from
Mar 6, 2019

Conversation

@baluchicken
Copy link
Contributor

@baluchicken baluchicken commented Mar 6, 2019

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

This PR fixes the ability to use multiple plugin crs. Now if multiple plugin crs are submitted the created ConfigMap will hold all cr related config instead of overwriting it.

Checklist

  • Implementation tested (with at least one cloud provider)
  • Error handling code meets the guideline
  • Logging code meets the guideline (TODO)
  • User guide and development docs updated (if needed)

@baluchicken baluchicken requested review from ahma and tarokkk March 6, 2019 12:02
@CLAassistant
Copy link

CLAassistant commented Mar 6, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@baluchicken baluchicken requested a review from bonifaido March 6, 2019 12:08
ahma
ahma approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @baluchicken

@ahma ahma merged commit 160036c into master Mar 6, 2019
@ahma ahma deleted the multiple_config branch March 6, 2019 12:21
simonkey007 pushed a commit to simonkey007/logging-operator that referenced this pull request Mar 11, 2021
@baluchicken @ahma
Allow to add multiple configuration file to configmap (kube-logging#66)
df6681b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahma ahma ahma approved these changes

@tarokkk tarokkk Awaiting requested review from tarokkk

@bonifaido bonifaido Awaiting requested review from bonifaido

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baluchicken @CLAassistant @ahma