Skip to content

add e2e tests: label based routing works #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 24, 2024
Merged

add e2e tests: label based routing works #12

merged 9 commits into from
Jan 24, 2024

Conversation

@OverOrion
Copy link
Collaborator

@OverOrion OverOrion commented Jan 12, 2024 •
edited
Loading

TODOs:

@OverOrion OverOrion force-pushed the subscription-labels branch 2 times, most recently from 905d4fd to c9fddcd Compare January 15, 2024 15:30
@OverOrion OverOrion marked this pull request as ready for review January 15, 2024 15:31
pepov
pepov reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly nits

@OverOrion OverOrion force-pushed the subscription-labels branch from c9fddcd to 2510c11 Compare January 23, 2024 16:08
@OverOrion
feat(otel col conf gen): add logging/debug
102d249 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
fix(otel col conf gen): routing statement quoting
57fa7d5 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
refactor(otel col conf gen): move debugging exporter to routing root
c53d165 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
feat(otel col conf gen): add note regarding crio parser
9ec226f 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion OverOrion force-pushed the subscription-labels branch from 2510c11 to 3dd4357 Compare January 23, 2024 16:12
@OverOrion
feat(test): add e2e test
9a58936 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
fix(test): simplify e2e test
a80ae41 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
docs(examples): rename another-subscription to subscription-2 for eas…
ea2ed60 
…ier grepping

Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion
feat(test): use docs/example for e2e test
81f5d49 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion OverOrion force-pushed the subscription-labels branch from 3dd4357 to 81f5d49 Compare January 24, 2024 06:58
kristofgyuracz
kristofgyuracz approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@kristofgyuracz kristofgyuracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pepov
pepov approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

@OverOrion
feat(e2e): simplify script
6595583 
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
@OverOrion OverOrion merged commit 842e672 into main Jan 24, 2024
@OverOrion OverOrion deleted the subscription-labels branch January 24, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pepov pepov pepov approved these changes

@kristofgyuracz kristofgyuracz kristofgyuracz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OverOrion @pepov @kristofgyuracz