Skip to content

test: add integration tests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2022
Merged

test: add integration tests #3

merged 3 commits into from
Dec 19, 2022

Conversation

@shaneutt
Copy link
Member

@shaneutt shaneutt commented Dec 15, 2022 •
edited
Loading

This PR adds some initial integration tests and adds them to ci workflows, and also includes some Cargo.toml cleanup according to #2, as the initial POC had an overloaded copy/pasted Cargo.toml.

Resolves #2

@shaneutt shaneutt added this to the Initial Pre-Release milestone Dec 15, 2022
@shaneutt shaneutt force-pushed the shaneutt/add-integration-tests branch from 73f5abb to a13711c Compare December 15, 2022 15:21
@shaneutt shaneutt marked this pull request as ready for review December 15, 2022 15:25
@shaneutt shaneutt force-pushed the shaneutt/add-integration-tests branch from a13711c to e797561 Compare December 15, 2022 15:28
@shaneutt shaneutt force-pushed the shaneutt/add-integration-tests branch 2 times, most recently from f1b11b8 to 918e600 Compare December 15, 2022 15:43
@shaneutt
Copy link
Member Author

shaneutt commented Dec 15, 2022 •
edited
Loading

@clux when you have some time if you wouldn't mind taking a look at this one and make sure this includes everything you had in mind for #2 done, I would appreciate it 🖖

@shaneutt shaneutt requested a review from clux December 15, 2022 15:48
@shaneutt shaneutt enabled auto-merge (rebase) December 15, 2022 15:48
clux
clux approved these changes Dec 19, 2022
View reviewed changes
@clux
Copy link
Member

clux commented Dec 19, 2022

Looks sensible to me!

@shaneutt shaneutt force-pushed the shaneutt/add-integration-tests branch 2 times, most recently from 84ee9e8 to a154bd2 Compare December 19, 2022 16:55
@shaneutt
test: add initial integration tests
d943503 
Signed-off-by: Shane Utt <shaneutt@linux.com>
@shaneutt
test: add ci workflow for integration tests
aa00caa 
Signed-off-by: Shane Utt <shaneutt@linux.com>
@shaneutt
fix: cleanup Cargo.toml
a154bd2 
Signed-off-by: Shane Utt <shaneutt@linux.com>
@shaneutt shaneutt merged commit 35ad82b into kube-rs:main Dec 19, 2022
@shaneutt shaneutt deleted the shaneutt/add-integration-tests branch December 19, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clux clux clux approved these changes

Assignees

No one assigned

Labels

area/maintenance area/tests

Projects

None yet

Milestone

v0.25.0

Development

Successfully merging this pull request may close these issues.

Crate should not default select kubernetes versions and kube features

2 participants

@shaneutt @clux