Skip to content

Commit a936042

Browse files
committed
Tighten CI/release workflow secrets, perms, and release notes
ci.yml: - Drop `set -x` from the "Prepare git" step so the git config insteadOf URL (which embeds GITHUB_TOKEN) is not echoed by bash trace. release.yml: - Switch ghcr.io login from the bot user `1gtm` / `LGTM_GITHUB_TOKEN` PAT to `github.actor` / `GITHUB_TOKEN`, relying on the `packages: write` permission already declared on the build job. - Drop the unused `contents: write` block from `label-detector`, which only runs a curl and emits a job output. - Add `generate_release_notes: true` to `softprops/action-gh-release` so GitHub auto-populates the release notes from commit history. Signed-off-by: Tamal Saha <tamal@appscode.com>
1 parent 570188e commit a936042

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ jobs:
4747
uses: softprops/action-gh-release@3bb12739c298aeb8a4eeaf626c5b8d85266b0e65 # v2.6.2
4848
if: startsWith(github.ref, 'refs/tags/')
4949
with:
50+
generate_release_notes: true
5051
files: |
5152
bin/kubectl-dba-darwin-amd64.tar.gz
5253
bin/kubectl-dba-darwin-arm64.tar.gz

0 commit comments

Comments
 (0)