feat: Convert Staged UpdateRun controller to use interfaces #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Arvindthiru
force-pushed
the
stagedUpdateRunController
branch
from
ddc0271 to
3508fd0
Compare
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Arvindthiru
force-pushed
the
stagedUpdateRunController
branch
from
94f005f to
54974ac
Compare
jwtty
reviewed
Oct 9, 2025
| } | ||
| klog.InfoS("Added the staged update run finalizer", "stagedUpdateRun", klog.KObj(updateRun)) | ||
| klog.InfoS("Added the updateRun finalizer", "updateRun", klog.KObj(updateRun)) | ||
| // TODO(arvindth): update the variable name for finalizer. |
There was a problem hiding this comment.
Do we only need to update the variable name but not the value?
There was a problem hiding this comment.
The value update is not backwards compatible we need special logic to handle conversion for existing updateRuns
There was a problem hiding this comment.
The current value is ClusterStagedUpdateRunFinalizer = FleetPrefix + "stagedupdaterun-finalizer". We probably do not need to change it at all.
added 2 commits
October 9, 2025 16:54
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
jwtty
approved these changes
Oct 10, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer