chore: 1 - remove v1alpha1 CRP and MC validation #302
Conversation
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
weng271190436
changed the title
| // TODO: remove after we remove v1alpha1 support | ||
| // disable v1alpha1 related resources by default | ||
| r.AddGroup(fleetv1alpha1.GroupVersion.Group) | ||
| r.AddGroupVersionKind(WorkV1Alpha1GVK) |
There was a problem hiding this comment.
I assume this can be removed too?
There was a problem hiding this comment.
If you want to do it in another PR, pls add a TODO comment.
There was a problem hiding this comment.
added a TODO comment. In fact I already have my next PR stacking on top of this one which is dedicated to removing v1alpha1work
| Version: fleetv1alpha1.GroupVersion.Version, | ||
| Resource: fleetv1alpha1.MemberClusterResource, | ||
| } | ||
|
|
There was a problem hiding this comment.
What about workV1alpha1 resources below?
There was a problem hiding this comment.
added a TODO comment. In fact I already have my next PR stacking on top of this one which is dedicated to removing v1alpha1work
| klog.V(2).InfoS("handling namespace resource", "name", req.Name, "operation", req.Operation, "subResource", req.SubResource) | ||
| response = v.handleNamespace(req) | ||
| case req.Kind == utils.IMCV1Alpha1MetaGVK || req.Kind == utils.WorkV1Alpha1MetaGVK || req.Kind == utils.IMCMetaGVK || req.Kind == utils.WorkMetaGVK || req.Kind == utils.EndpointSliceExportMetaGVK || req.Kind == utils.EndpointSliceImportMetaGVK || req.Kind == utils.InternalServiceExportMetaGVK || req.Kind == utils.InternalServiceImportMetaGVK: | ||
| case req.Kind == utils.WorkV1Alpha1MetaGVK || req.Kind == utils.IMCMetaGVK || req.Kind == utils.WorkMetaGVK || req.Kind == utils.EndpointSliceExportMetaGVK || req.Kind == utils.EndpointSliceImportMetaGVK || req.Kind == utils.InternalServiceExportMetaGVK || req.Kind == utils.InternalServiceImportMetaGVK: |
There was a problem hiding this comment.
ditto, WorkV1apha1 is another v1alpha1 API that we'd like to remove. Do you want to do it in another PR?
There was a problem hiding this comment.
added a TODO comment. In fact I already have my next PR stacking on top of this one which is dedicated to removing v1alpha1work
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
2 participants
Description of your changes
remove v1alpha1 CRP and MC validation
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer