fix: fix rollout controller not rollout when type is changed from External to RollingUpdate #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwtty
force-pushed
the
rollout-type-fix
branch
2 times, most recently
from
c0a4c10 to
cf7a863
Compare
britaniar
reviewed
Apr 23, 2025
britaniar
reviewed
Apr 23, 2025
britaniar
reviewed
Apr 23, 2025
jwtty
force-pushed
the
rollout-type-fix
branch
2 times, most recently
from
94d5ea5 to
e6105fe
Compare
| verifyBindingsNotRolledOutConsistently(bindings) | ||
|
|
||
| By("Updating CRP rollout strategy type to empty") | ||
| rolloutCRP.Spec.Strategy.Type = "" |
Contributor
There was a problem hiding this comment.
is this allowed? Don't our webhook/API definition/CEL block this?
Collaborator
Author
There was a problem hiding this comment.
I tried in prod. This is allowed.
Collaborator
There was a problem hiding this comment.
Default value is used if empty.
… to RollingUpdate Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
ryanzhang-oss
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When CRP rollout strategy is changed from
ExternaltoRollingUpdate, the rollout is not triggered. This PR fixes this issue.Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer