Skip to content

Conversation

@vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented Jun 28, 2025

🔄 Pull Request

📝 Description

Brief description of changes and motivation.

  • Remove Makefile and replace with comprehensive Taskfile.yml
  • Add 20+ task definitions covering all development workflows
  • Update documentation references from make to task commands
  • Improve cross-platform support (Windows, macOS, Linux)
  • Add background service management with clean start/stop workflow
  • Auto-install uv dependency when running task install
  • Fix MCP Inspector background execution

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📖 Documentation update
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

🧪 Testing

  • ✅ All existing tests pass (uv run pytest)
  • 🔬 Tested with MCP Inspector
  • 📊 Tested with sample Spark data
  • 🚀 Tested with real Spark History Server (if applicable)

🔬 Test Commands Run

# Example:
# uv run pytest test_tools.py -v
# npx @modelcontextprotocol/inspector uv run main.py

🛠️ New Tools Added (if applicable)

  • Tool Name: new_tool_name
  • Purpose: What it does
  • Usage: Example parameters

📸 Screenshots (if applicable)

✅ Checklist

  • 🔍 Code follows project style guidelines
  • 🧪 Added tests for new functionality
  • 📖 Updated documentation (README, TESTING.md, etc.)
  • 🔧 Pre-commit hooks pass
  • 📝 Added entry to CHANGELOG.md (if significant change)

📚 Related Issues

Fixes #2

🤔 Additional Context


🎉 Thank you for contributing! Your effort helps make Spark monitoring more intelligent.

@vara-bonthu vara-bonthu requested a review from nabuskey June 28, 2025 23:38
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
@vara-bonthu vara-bonthu force-pushed the task-migration-makefile-replacement branch from 42c38f0 to 3fd176f Compare June 28, 2025 23:40
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
@nabuskey nabuskey merged commit 341a63a into main Jun 29, 2025
5 checks passed
@vara-bonthu vara-bonthu deleted the task-migration-makefile-replacement branch July 24, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to Task

3 participants