Skip to content

Conversation

@vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented Jun 30, 2025

πŸ”„ Pull Request

πŸ“ Description

Brief description of changes and motivation.

Features Added:

β€’ STDIO Transport Entry Point - Added main_stdio.py for Claude Desktop and Amazon Q CLI integration using official MCP SDK
β€’ Claude Desktop Integration - Complete setup guide with configuration examples and 6 core analysis tools
β€’ Amazon Q CLI Integration - Command-line Spark analysis with batch processing capabilities and automation examples
β€’ Multi-Transport Architecture - Preserves existing FastMCP HTTP server while adding STDIO support for different client types

Improvements:

β€’ Simplified Documentation - Consolidated scattered setup instructions into single clear paths
β€’ Taskfile Integration - Updated all docs to use consistent task commands instead of mixed uv/shell scripts
β€’ Tool Clarity - Clear distinction between 6 core STDIO tools vs 18 comprehensive HTTP tools
β€’ Remote Server Support - Configuration guidance for connecting to production Spark History Servers

Fixes:

β€’ Pre-commit Integration - Fixed Taskfile to use uv run pre-commit for consistent developer experience
β€’ Code Quality - Resolved linting issues (bare except clauses, print statements) in STDIO entry point
β€’ Path Resolution - Realistic path examples and clear replacement instructions for different environments

Docs:

β€’ Removed Duplication - Eliminated redundant setup sections between main README and testing docs
β€’ Streamlined Testing - Simplified TESTING.md from 3 approaches to 1 recommended path
β€’ Integration Comparison - Added clear table showing transport types, entry points, and use cases
β€’ Prerequisites Cleanup - Moved detailed setup to individual integration docs, kept main README focused

🎯 Type of Change

  • πŸ› Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ“– Documentation update
  • πŸ§ͺ Test improvement
  • πŸ”§ Refactoring (no functional changes)

πŸ§ͺ Testing

  • βœ… All existing tests pass (task test)
  • πŸ”¬ Tested with MCP Inspector
  • πŸ“Š Tested with sample Spark data
  • πŸš€ Tested with real Spark History Server (if applicable)

πŸ”¬ Test Commands Run

# Example:
# task test
# npx @modelcontextprotocol/inspector uv run main.py

πŸ› οΈ New Tools Added (if applicable)

  • Tool Name: new_tool_name
  • Purpose: What it does
  • Usage: Example parameters

πŸ“Έ Screenshots (if applicable)

βœ… Checklist

  • πŸ” Code follows project style guidelines
  • πŸ§ͺ Added tests for new functionality
  • πŸ“– Updated documentation (README, TESTING.md, etc.)
  • πŸ”§ Pre-commit hooks pass
  • πŸ“ Added entry to CHANGELOG.md (if significant change)

πŸ“š Related Issues

Fixes #(issue number)
Related to #(issue number)

πŸ€” Additional Context


πŸŽ‰ Thank you for contributing! Your effort helps make Spark monitoring more intelligent.

Fix pre-commit tasks to use 'uv run pre-commit' instead of bare 'pre-commit'
to ensure commands work for all users regardless of global pre-commit installation.

This prevents 'executable file not found' errors when running:
- task pre-commit
- task pre-commit-install

Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
Signed-off-by: vara-bonthu <vara.bonthu@gmail.com>
@vara-bonthu vara-bonthu force-pushed the claude-desktop-integration branch from 38a018f to d788298 Compare June 30, 2025 03:23
@vara-bonthu vara-bonthu requested a review from nabuskey June 30, 2025 03:24
@vara-bonthu vara-bonthu changed the title feat: Claude desktop integration feat: Claude desktop and Amazon Q CLI integration Jun 30, 2025
Copy link
Collaborator

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will look into supporting stdio mode without a separate file.

@nabuskey nabuskey merged commit 239a5e7 into main Jun 30, 2025
5 checks passed
@vara-bonthu vara-bonthu deleted the claude-desktop-integration branch July 24, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants