Skip to content

Conversation

@thesuperzapper
Copy link
Member

Currently the owners file lists many people who are not maintainers.

This is a problem because all PRs are being assigned to people who are not related to the Notebooks development and slowing down the time to get a review.

NOTE: This PR only updates the notebooks-v2 branch, but we should make one for main also.

…view)

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@zijianjoy
Copy link
Contributor

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3e89605 into kubeflow:notebooks-v2 Jun 24, 2024
@thesuperzapper thesuperzapper deleted the notebooks-v2--update-owners branch June 24, 2024 19:57
@thesuperzapper
Copy link
Member Author

@zijianjoy thanks, there is also another PR for the main branch:

#18

Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 29, 2024
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 29, 2024
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 29, 2024
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
mkoushni pushed a commit to mkoushni/notebooks that referenced this pull request May 28, 2025
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: CI Bot <mkoushni@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants