feat(ws): add auth to backend #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
thesuperzapper
requested review from
ederign
and removed request for
kimwnasptd
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Member
|
@thesuperzapper, impressive PR. This approach is indeed smart! :) As an FUP, I'll add the authorization mocks for the front end (in the standalone). After 1.10 release, I"ll also upgrade Model Registry auth for this. Great work |
ederign
approved these changes
Feb 11, 2025
Member
|
/lgtm |
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mohamed-ben-khemis
pushed a commit
to Mohamed-ben-khemis/notebooks
that referenced
this pull request
Mar 13, 2025
* feat(ws): add auth to backend Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * add `DISABLE_AUTH` for interim testing (enabled by default) Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
* feat(ws): add auth to backend Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * add `DISABLE_AUTH` for interim testing (enabled by default) Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
* feat(ws): add auth to backend Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * add `DISABLE_AUTH` for interim testing (enabled by default) Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
helper.GetKubeconfigand replaces it withctrl.GetConfig()CLIENT_QPSandCLIENT_BURSTas configs (because the defaults are very low 20/30)Authentication is implemented by reading the
USERID_HEADERandGROUPS_HEADERin each request (seeNewRequestAuthenticator()).Authorization is implemented with SubjectAccessReviews (see
NewRequestAuthorizer()). TheNewRequestAuthorizer()method uses theauthorizerfactory.DelegatingAuthorizerConfigfromk8s.io/apiserver/pkg/authorization/authorizerfactoryand has a 10-second cache to not check the user is still authorized more than once every 10 seconds.To define what auth a specific handler requires, we have a new
a.requireAuth()method, which takes a new[]ResourcePolicylist, that can easily be constructed usingNewResourcePolicy()in a clear way.