-
Notifications
You must be signed in to change notification settings - Fork 69
feat(ws): update JSON field names to camelCase in types and README. #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
|
@paulovmr, could you please review this one to see if it fits your needs? |
|
/assign @paulovmr |
paulovmr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ederign !
|
/lgtm |
|
@thesuperzapper, when you have a chance, would you mind reviewing this? Or, as @paulovmr tested and approved (from FE perspective), you can lgtm to unblock FE development, and I can accommodate your eventual requests later in a FUP PR. |
|
@ederign sorry for the delay, this looks good for now, if someone finds an instance of I mean you could also just do a quick project wide search for all instances of Approving for now to unblock. /ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulovmr, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
365c44b
into
kubeflow:notebooks-v2
…ubeflow#214) Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
…ubeflow#214) Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
…ubeflow#214) Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
…ubeflow#214) Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
…ubeflow#214) Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
To make FE/Typescript marshaling straightforward, we default our JSON format to camelCase.
Some tests: