feat(ws): Apply theme dependent components #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
force-pushed
the
theme-dependent-components
branch
3 times, most recently
from
f7351d5 to
3673008
Compare
jenny-s51
force-pushed
the
theme-dependent-components
branch
10 times, most recently
from
d187369 to
9874518
Compare
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting errors Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> move button to toolbargroup to fix toolbar alignment fix search input height fix frontend tests Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix testing issues Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add export default to ThemeAwareSearchInput Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting issues fix import add ID Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add whitespace remove whitespace Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tests
jenny-s51
force-pushed
the
theme-dependent-components
branch
from
d945767 to
2c67dc9
Compare
|
/ok-to-test |
ederign
approved these changes
May 19, 2025
Member
|
/lgtm |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting errors Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> move button to toolbargroup to fix toolbar alignment fix search input height fix frontend tests Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix testing issues Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add export default to ThemeAwareSearchInput Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting issues fix import add ID Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add whitespace remove whitespace Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tests Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 4, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting errors Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> move button to toolbargroup to fix toolbar alignment fix search input height fix frontend tests Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix testing issues Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add export default to ThemeAwareSearchInput Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting issues fix import add ID Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add whitespace remove whitespace Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tests Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting errors Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> move button to toolbargroup to fix toolbar alignment fix search input height fix frontend tests Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix testing issues Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add export default to ThemeAwareSearchInput Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix linting issues fix import add ID Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> add whitespace remove whitespace Signed-off-by: Jenny <32821331+jenny-s51@users.noreply.github.com> fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263 and #312.
Introduced FormFieldset and ThemeAwareSearchInput components to encapsulate conditional MUI theme logic for these components.
Refactored existing components to use these new theme-aware wrappers.
Before:
After:
