feat(ws): create new script to start frontend returning mocked data #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/ok-to-test |
paulovmr
reviewed
May 8, 2025
paulovmr
left a comment
paulovmr
left a comment
There was a problem hiding this comment.
@caponetto LGTM! As we talked, let's wait to merge #303 before this one.
caponetto
force-pushed
the
RHOAIENG-24599
branch
3 times, most recently
from
04a0d59 to
0c96cc8
Compare
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
…ngly Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
ederign
approved these changes
May 13, 2025
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
This was referenced May 22, 2025
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
…ubeflow#314) * Enable start:dev with real data and start:dev:mock with mocked data Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize mock-related code Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Refactor FE types according to BE types and adapt the FE code accordingly Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize types Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Prepare code for create/update/patch Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Format files with prettier Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Clean up unnecessary eslint comments Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Minor adjustments after rebase Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add error boundary Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add EnsureAPIAvailability component Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add instructions for running the UI with a mocked API Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Enable create workspace Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> --------- Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 4, 2025
…ubeflow#314) * Enable start:dev with real data and start:dev:mock with mocked data Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize mock-related code Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Refactor FE types according to BE types and adapt the FE code accordingly Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize types Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Prepare code for create/update/patch Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Format files with prettier Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Clean up unnecessary eslint comments Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Minor adjustments after rebase Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add error boundary Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add EnsureAPIAvailability component Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add instructions for running the UI with a mocked API Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Enable create workspace Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> --------- Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 11, 2025
…ubeflow#314) * Enable start:dev with real data and start:dev:mock with mocked data Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize mock-related code Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Refactor FE types according to BE types and adapt the FE code accordingly Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize types Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Prepare code for create/update/patch Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Format files with prettier Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Clean up unnecessary eslint comments Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Minor adjustments after rebase Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add error boundary Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add EnsureAPIAvailability component Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add instructions for running the UI with a mocked API Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Enable create workspace Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> --------- Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 11, 2025
…ubeflow#314) * Enable start:dev with real data and start:dev:mock with mocked data Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize mock-related code Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Refactor FE types according to BE types and adapt the FE code accordingly Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize types Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Prepare code for create/update/patch Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Format files with prettier Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Clean up unnecessary eslint comments Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Minor adjustments after rebase Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add error boundary Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add EnsureAPIAvailability component Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add instructions for running the UI with a mocked API Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Enable create workspace Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> --------- Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Signed-off-by: CI Bot <mkoushni@redhat.com>
andyatmiami
pushed a commit
to andyatmiami/kubeflow-notebooks
that referenced
this pull request
Jun 13, 2025
…ubeflow#314) * Enable start:dev with real data and start:dev:mock with mocked data Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize mock-related code Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Refactor FE types according to BE types and adapt the FE code accordingly Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Reorganize types Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Prepare code for create/update/patch Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Format files with prettier Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Clean up unnecessary eslint comments Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Minor adjustments after rebase Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add error boundary Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add EnsureAPIAvailability component Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Add instructions for running the UI with a mocked API Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> * Enable create workspace Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> --------- Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269
In this PR:
start:devwith real data andstart:dev:mockwith mocked data