test(tb): Migrate TBC test-related workflows from kubeflow/kubeflow to notebooks-v1 branch

[ishavkon]

resolves #591

migrate the files below to kubeflow/notebooks-v1 branch:

• tb_controller_multi_arch_test.yaml
• tb_controller_integration_test.yaml

[andyatmiami]

Thank you for your contributions - changes I am requesting are hopefully obvious/straightforward...

also please be aware - depending on which notebooks-v1 workflow PR is ready to merge first - we may also need a rebase as some of the testing/gh-actions files are also being created in additional PRs being raised.

[andyatmiami]

/ok-to-test

[andyatmiami]

Thanks for your continued engagement.. getting closer to having something merge-able.. but still need to do a little more refining.

Please reach out to me if you need/want more details about how you can test this on your fork to gain confidence in its functionality on the upstream repo.

[andyatmiami]

Thanks again for your continued attention to this PR... just a couple more things to clear up..

• please ensure the DCO checks on your PR are passing.. you can probably squash some/all of your commits if you want to avoid having to make sure each one is signed
• fix up the indenting that was introduced (i'm guessing unintentionally) to kind-1-25.yaml

[andyatmiami]

Looks like you introduced an indentation here that was not present in the source originally:

• https://github.com/kubeflow/kubeflow/blob/master/components/testing/gh-actions/kind-1-25.yaml#L4-L7

Preserving original formatting will avoid a merge conflict if/as some other PR that includes this file gets merged first.

Suggested change

	- |-
	[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"]
	endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"]
	- |-
	[plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"]
	endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"]

[andyatmiami]

Looks like you introduced an indentation here that was not present in the source originally:

• https://github.com/kubeflow/kubeflow/blob/master/components/testing/gh-actions/kind-1-25.yaml#L20-L24

Preserving original formatting will avoid a merge conflict if/as some other PR that includes this file gets merged first.

Suggested change

	nodes:
	- role: control-plane
	image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
	- role: worker
	image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
	nodes:
	- role: control-plane
	image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1
	- role: worker
	image: kindest/node:v1.25.3@sha256:f52781bc0d7a19fb6c405c2af83abfeb311f130707a0e219175677e366cc45d1

[andyatmiami]

/lgtm

Thanks for all this work @ishavkon - appreciate your responsiveness in working through my comments.

I'm comfortable with the changes and have verified the workflows behave as expected.

Tested on my fork:

• andyatmiami#56

[andyatmiami]

/lgtm

[kimwnasptd]

Thank you for the great work @ishavkon and the thorough reviews @andyatmiami!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kimwnasptd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment