Skip to content

Conversation

@astefanutti
Copy link
Contributor

What this PR does / why we need it:

ClusterTrainingRuntime resources are not namespace-scoped so the namespace info is not relevant.

Checklist:

  • Docs included if any changes are user facing

…messages

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19458842273

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.596%

Totals Coverage Status
Change from base Build 19231750341: 0.0%
Covered Lines: 2506
Relevant Lines: 3763

💛 - Coveralls

Copy link
Contributor

@kramaranya kramaranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 49a5087 into kubeflow:main Nov 18, 2025
14 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.3 milestone Nov 18, 2025
@astefanutti astefanutti deleted the pr-05 branch November 18, 2025 11:08
Shekharrajak pushed a commit to Shekharrajak/sdk that referenced this pull request Nov 19, 2025
…messages (kubeflow#166)

Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
@kramaranya
Copy link
Contributor

/cherry-pick release-0.2

@google-oss-robot
Copy link

@kramaranya: new pull request created: #175

In response to this:

/cherry-pick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants