Improve nil pointer checks and consider VPC overlay networks for Nutanix #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
release-note
Contributor
Author
|
/hold I'd like to test this, but we do not have a VPC overlay network yet. |
kubermatic-bot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
Contributor
|
LGTM label has been added. Git tree hash: b46433dc51fd4b91c31659aee3fe27b1c356c281
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, moadqassem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our Nutanix provider implementation assumed that all networks would have a cluster reference. That does not seem to be the case, as e.g. VPC overlay networks do not have one (also see nutanix/terraform-provider-nutanix#328).
This PR includes that as a possible scenario when checking the cluster reference on a discovered subnet.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>format, will close the issue(s) when PR gets merged):Fixes #1192
Special notes for your reviewer:
Optional Release Note:
Signed-off-by: Marvin Beckers marvin@kubermatic.com