Skip to content

Validate max price in spot instance request #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2022
Merged

Validate max price in spot instance request #1198

merged 1 commit into from
Feb 28, 2022

Conversation

@moadqassem
Copy link
Member

@moadqassem moadqassem commented Feb 25, 2022

What this PR does / why we need it:
Makes sure that we validate the max price field of the machine deployment spec when the aws instance is marked as spot instance.

Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #1197

Special notes for your reviewer:

Optional Release Note:

None

@moadqassem
validate max price in spot instance request
179dea6 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. labels Feb 25, 2022
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2022
@moadqassem moadqassem changed the title validate max price in spot instance request Validate max price in spot instance request Feb 25, 2022
ahmedwaleedmalik
ahmedwaleedmalik reviewed Feb 25, 2022
View reviewed changes
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2022
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 25, 2022

LGTM label has been added.

Git tree hash: 46f9e3e78220f14aa617049844a36465c8c0897a

@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Feb 25, 2022

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2022
@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Feb 25, 2022

/unhold
/retest
/lgtm

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2022
@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Feb 25, 2022

/unhold
/retest

1 similar comment
@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Feb 25, 2022

/unhold
/retest

@kubermatic-triage-bot
Copy link

kubermatic-triage-bot commented Feb 25, 2022

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

kubermatic-triage-bot commented Feb 25, 2022

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kron4eg
Copy link
Member

kron4eg commented Feb 25, 2022

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2022
@moadqassem
Copy link
Member Author

moadqassem commented Feb 28, 2022

/test pull-machine-controller-e2e-hetzner

@moadqassem
Copy link
Member Author

moadqassem commented Feb 28, 2022

/retest

1 similar comment
@moadqassem
Copy link
Member Author

moadqassem commented Feb 28, 2022

/retest

@moadqassem
Copy link
Member Author

moadqassem commented Feb 28, 2022

/unhold

cc @kron4eg

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2022
@kubermatic-bot kubermatic-bot merged commit be72ced into kubermatic:master Feb 28, 2022
@moadqassem moadqassem deleted the fix-aws-spot-instance-props branch February 28, 2022 22:45
LittleFox94 pushed a commit to anexia-it/machine-controller that referenced this pull request Mar 16, 2022
@moadqassem @LittleFox94
validate max price in spot instance request (kubermatic#1198)
a99dac7 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik left review comments

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate spot instances required specs

5 participants

@moadqassem @kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot @kron4eg